[no squash] Windows CI/build improvements #14098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably a leftover of when CMake didn't automatically detect the revision from git.
sfan5
added
@ Build
sfan5
force-pushed
the
mwci
branch
3 times, most recently
from
9d5d6da
to
f23fc6b
Compare
grorp
reviewed
Dec 14, 2023
There was a problem hiding this comment.
The changes look good to me.
I tested both MinGW builds on Windows 10 x86_64. The 64-bit build worked, but the 32-bit build didn't start. It only opened an empty window, which closed again shortly afterwards. The only thing it left in debug.txt is this:
-------------
Separator
-------------
I then tested the official minetest-5.8.0-win32 build, which unfortunately showed the same problem. minetest-5.7.0-win32 works as expected.
I guess this problem is unrelated to this PR?
Yes. |
grorp
approved these changes
Dec 15, 2023
|
FWIW the win32 build doesn't work for me either, no idea what's up with that. When running it in Wine it shows a stacktrace with a crash somewhere inside irrlichtmt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this get us: