Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinGW toolchain refresh #14099

Merged
merged 1 commit into from Dec 17, 2023
Merged

MinGW toolchain refresh #14099

merged 1 commit into from Dec 17, 2023

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Dec 13, 2023 •
edited

counterpart: minetest/irrlicht#260

This gets us an up-to-date compiler and libraries in addition to the more modern UCRT runtime¹.

¹: in #14015 it was speculated that this could help

@sfan5 sfan5 added @ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Windows labels Dec 13, 2023
@sfan5 sfan5 marked this pull request as ready for review December 15, 2023 12:11
@lhofhansl
Copy link
Contributor

lhofhansl commented Dec 16, 2023 •
edited

Looks good. I'll have to trust on this, though, since I have no windows tool chain setup to verify.
Build CI on Windows worked, though. So ... good. :)

I can test a binary, though, on my son's computer.

@sfan5
Copy link
Member Author

sfan5 commented Dec 16, 2023 •
edited

FYI: the win32 one might be broken due to https://irc.minetest.net/minetest-dev/2023-12-15#i_6139666.
This isn't solved by this PR but also not caused by it.

SmallJoker
SmallJoker approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Gave the MinGW 64 build a quick test in Wine. Works.

@sfan5 sfan5 merged commit 5d3e830 into minetest:master Dec 17, 2023
13 checks passed
@sfan5 sfan5 deleted the mwre branch December 17, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️ Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfan5 @lhofhansl @SmallJoker