New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for restoring Pseudorandom and PcgRandom state #14123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from this. (Small note: I don't really care what happens to PseudoRandom as it is strictly inferior to PcgRandom, see #14180).
@appgurueu @sfan5 Should be resolved now. |
b043ad0
to
189dfb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise the code looks fine. I'm not happy with how PseudoRandom
uses int
rather than a fixed-size type (which might be related to bugs like #14237), but that is out of scope for this PR to fix.
4cbac87
to
3c3031d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works. Thanks for the PR!
Include review and formatting feedback.
f00a72a
to
0129d1a
Compare
Rebased, conflicts solved. Failure for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than that
Add compact, short information about your PR for easier understanding:
To do
This PR is Ready for Review.
How to test
Run
/unittests
command from devtest game andminetest --run-unittests
command from system.