Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable segment heap on Windows #14127

Merged
merged 1 commit into from Dec 20, 2023
Merged

Enable segment heap on Windows #14127

merged 1 commit into from Dec 20, 2023

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Dec 19, 2023

It turns out Microsoft has magic knobs you can turn to improve things, you just need to know about them.

this is supposed to help with #14015 and (allegedly) also lowers memory usage

@lhofhansl is probably in the best position to test this

according to the docs it only does something on version 2004 (build 19041) or later.

To do

This PR is Ready for Review.

How to test

@lhofhansl
Copy link
Contributor

lhofhansl commented Dec 20, 2023

I can take the artifacts generated by the build script and test it on the my son's desktop :)
Lemme try this one.

This didn't trigger a build, though. :(

@sfan5
Copy link
Member Author

sfan5 commented Dec 20, 2023

Try now.

@lhofhansl
Copy link
Contributor

lhofhansl commented Dec 20, 2023

This is sooo much better!

Still some stuttering when meshes are build, but instead of over 200ms, the worst I have seen is around 50ms, and most of the time it hovers around 20-30ms.

And absolutely no hanging on shutdown.

This is usable now at large viewing_ranges!

Strange that Windows needs these obscure settings instead of just doing the right thing.

@lhofhansl
Copy link
Contributor

We might even want to backport this to a 5.8.1.

@sfan5 sfan5 merged commit 47e557b into minetest:master Dec 20, 2023
13 checks passed
@sfan5 sfan5 deleted the obscuremagic branch December 20, 2023 20:23
@lhofhansl
Copy link
Contributor

Actually I now notice that the MT actually crashes when you exit a game :(

I did not notice before, because I was exiting to the OS and Windows gave no indication about that. (Maybe that's why there was absolutely no wait upon exit.)

But when I "Exit to Menu" I see that it crashes. Meh.

The in-game performance is still awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants