Code style: Use non-static member initialisation instead of member initialiser lists for shader uniform names #14227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itialiser lists for shader uniform names Before this change, the member type and member name are at one place, and the member name and uniform name are at another place. If the uniform name is written directly at the member declaration, the member type, member name and uniform name are all at one place, which leads to shorter code and may be easier to read.
wsor4035
added
Maintenance
appgurueu
approved these changes
Jan 11, 2024
sfan5
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the member type and member name are at one place, and the member name and uniform name are at another place.
If the uniform name is written directly at the member declaration, the member type, member name and uniform name are all at one place, which leads to shorter code and may be easier to read.
According to the code style guidelines, initializer lists should only be used when absolutely necessary, but I don't know if that is about std::initializer_list or member initialiser lists.
Roadmap goal: 2.2 Internal code refactoring
To do
This PR is a Ready for Review.
How to test
Read the code before and after the changes