Slight optimizations in ClientMap #14251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhofhansl
added
Maintenance
lhofhansl
commented
Jan 12, 2024
| @@ -1245,11 +1245,6 @@ void ClientMap::updateDrawListShadow(v3f shadow_light_pos, v3f shadow_light_dir, | |||
| { | |||
| ScopeProfiler sp(g_profiler, "CM::updateDrawListShadow()", SPT_AVG); | |||
|
|
|||
| v3s16 cam_pos_nodes = floatToInt(shadow_light_pos, BS); | |||
There was a problem hiding this comment.
This is unused. I traced back the commit history, and this was never used. Looks like an accidental cut-n-paste.
If I ever figure out #14239 (if that's even possible) I'm going to re-add this. Until then it's dead code.
|
Fastest review in the West :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unused code, and use
MapBlock::getPosRelative()where possible, we have this method just for this purpose.(Aside:
getPosRelative()should probably be renamed togetPosNodes(), but that for another PR)Goal of the PR
Slight performance improvement, code maintenance.
How does the PR work?
Does it resolve any reported issue?
Does this relate to a goal in the roadmap?
If not a bug fix, why is this PR needed? What usecases does it solve?
To do
This PR is Ready for Review.
How to test
No functional changes... Join any world. Make sure everything is still rendered correctly.