Return to the main menu if a shader compilation fails

[HybridDog]

Before this change, if the shaders are broken, only an error message is shown and the player enters the world nonetheless, where he/she sees broken graphics. For a shader developer, being thrown back to the main menu can be more convenient.

To throw the player back to the main menu, we add an exception. Since BaseException is only catched if NDEBUG is set, we add a new exception dedicated to shaders.

Closes: #10097
Previous pull request: #10240

To do

This PR is a Ready for Review.

How to test

• Execute this in a Bash Shell:

  <<< nyan cat >> client/shaders/nodes_shader/opengl_fragment.glsl

• Enter the game

[sfan5]

tested and works

[grorp]

Also: For a better developer experience, the error message shown in the GUI should contain the actual error message from Irrlicht, not just a generic "shader compilation failed".

[HybridDog]

How can I capture Irrlicht's error message, which arrives at MyEventReceiver::OnEvent?

[grorp]

How can I capture Irrlicht's error message, which arrives at MyEventReceiver::OnEvent?

64df516

What about this?

[sfan5]

Capturing the log messages from under the log subsystem only to put them into your exception text smells like a giant hack.

[grorp]

Capturing the log messages from under the log subsystem only to put them into your exception text smells like a giant hack.

It is, but less hacky approaches would require Irrlicht changes.

[HybridDog]

64df516

What about this?

I have moved the log capturing into the class but now it's a lot of code.

stale

[sfan5]

It is, but less hacky approaches would require Irrlicht changes.

The less hacky approach is to not do this.

[grorp]

I approve this PR both with and without 87c6497. However, I wonder about the amount of list-initialization in 87c6497.

The less hacky approach is to not do this.

I think getting a useful error message in the GUI is important. But I understand if you think it's not worth the hackyness.

[HybridDog]

I have reverted the Irrlicht message capturing change for simplicity.

[SmallJoker]

Works. LGTM. With and without the log capturing mechanism. It could still be added later for convenience.