Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer IrrlichtMt #14268

Merged
merged 1 commit into from Jan 19, 2024
Merged

Use newer IrrlichtMt #14268

merged 1 commit into from Jan 19, 2024

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Jan 17, 2024

now with SDL2
Fixes #14131

@sfan5 sfan5 force-pushed the irr14 branch 2 times, most recently from 5aa64ac to 38f6554 Compare January 17, 2024 17:36
@lhofhansl
Copy link
Contributor

Tried. Works.

now with SDL2
@superfloh247
Copy link
Contributor

MacOS 14.2, apple silicon

works

@sfan5
Copy link
Member Author

sfan5 commented Jan 18, 2024

@superfloh247 can you maybe also test with -DUSE_SDL2=1?
if everything works the About tab should show "irrlicht device: SDL".

@superfloh247
Copy link
Contributor

Irrlicht lastest master or a specific tag?

@sfan5
Copy link
Member Author

sfan5 commented Jan 18, 2024

Latest master or 1.9.0mt14 either is okay.

@superfloh247
Copy link
Contributor

superfloh247 commented Jan 18, 2024

-- Found SDL2: SDL2::SDL2
-- Found IrrlichtMt 1.9.0.14

compiles, no issues

noteworthy:

  • HUD elements and texts are way larger
  • shift keys (left and right) to fly downwards do not work
  • FPS approx up to 50% lower than usual values, sometimes almost the same

-USE_SDL2=1
Bildschirmfoto 2024-01-18 um 12 17 14

w/o any extra SDL parameter to cmake, Irrlicht Device: OSX
Bildschirmfoto 2024-01-18 um 12 28 00

@sfan5
Copy link
Member Author

sfan5 commented Jan 18, 2024

Looks like that needs some work but good to know it works in principle.
Thanks for testing.

@superfloh247
Copy link
Contributor

Glad to help

@sfan5 sfan5 merged commit 699d1bf into minetest:master Jan 19, 2024
15 checks passed
@sfan5 sfan5 deleted the irr14 branch January 19, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add sdl2 package to compiling instructions
3 participants