New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define strlcpy only on platforms where it's not available #14269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failure example:
|
appgurueu
approved these changes
Jan 17, 2024
Verified, works now: https://gitlab.alpinelinux.org/okias/aports/-/jobs/1247069 |
sfan5
reviewed
Jan 17, 2024
okias
force-pushed
the
detect-strlcpy
branch
4 times, most recently
from
January 17, 2024 22:58
caf473d
to
1b7b34c
Compare
Linux musl-libc and recent glibc > 2.38 have it. Signed-off-by: David Heidelberg <david@ixit.cz>
sfan5
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be smart, do not list platforms and combination which has
strlcpy
, but detect it.Right now, we conflict with some variation used on musl-libc on ppc64le. This should resolve it.
Btw. recently released glibc have it (we can forgive Ulrich Drepper now 🤣 )