[no squash] General fixes & improvements (season 2) #14286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
added
Maintenance
SmallJoker
changed the title
I hope this helped. |
SmallJoker
reviewed
Jan 20, 2024
SmallJoker
reviewed
Jan 20, 2024
|
I tested this PR a bit, especially the media requests and everything still seems to work while it fixes the reported issues, well done 😃 |
sfan5
added
the
Action / change needed
sfan5
removed
the
Action / change needed
I had to throw away the code switching sendRequestedMedia to a bin packing algorithm because it actually performed worse. :(
SmallJoker
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can someone help me name my PRs?
To do
This PR is Ready for Review.
How to test
check that it's not broken