Touchscreen: Camera movement improvements #14301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorp
added
Android
Feature ✨
Zughy
added
Testing needed
Supported by core dev
grorp
force-pushed
the
move-camera-while-digging
branch
from
fcbc7fc
to
cafc9a1
Compare
grorp
changed the title
grorp
force-pushed
the
move-camera-while-digging
branch
from
7be27e2
to
53dc7f6
Compare
grorp
added
the
Waiting (on dependency)
grorp
force-pushed
the
move-camera-while-digging
branch
from
53dc7f6
to
a287858
Compare
grorp
removed
the
Waiting (on dependency)
srifqi
approved these changes
Feb 27, 2024
|
I assume your approval applies even though you didn't add the "One approval" label? I'd like this PR to get more testing before it's merged, but no players have shown interest in testing it for 1+ month. Merging it seems to be the only way for it to get more testing. If you didn't notice a difference, the changes may have less impact than I expected anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11003.
On touchscreens, you can currently only move your camera while digging if
touch_use_crosshair = trueis set. This is an arbitrary and unnecessary limitation. The Android version of Minecraft doesn't have this issue. An example where it is especially annoying: If you're charging a bow in MineClone 2, you can't aim if you don't enabletouch_use_crosshair.This PR removes this limitation.
This PR also adjusts
touchscreen_sensitivityto the display density to avoid too fast camera movement on high-DPI displays. The effective sensitivity stays the same forxhdpidisplays, which is the most common density according to https://developer.android.com/about/dashboards/.Additionally, this PR removes the visible camera jump when you cross the touchscreen_threshold.
To do
This PR is a Ready for Review.
Looking for feedback from touchscreen players.
How to test
Try moving the camera while digging (or aiming a bow in MineClone 2) with
touch_use_crosshair = false.