New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two tiny doc things, combine regression fix #14314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix for the regression works.
The two documentation improvements could be squashed into one "Minor documentation fixes" commit.
the old checks were too strict
Replaced the fix with my own commit as discussed on IRC. |
I haven't tested the last commit well yet, but the logic should check out, and stuff (like signs) still looks right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will trust your testing
Tested. Code: minetest.after(1, function()
local E = minetest.formspec_escape
local t = {"size[4,4]"}
for x = 0, 1 do
for y = 0, 1 do
local tmod = ("[combine:2x2:0,0=rgbv.png:%d,%d=rgbv.png"):format(2*x-1, 2*y-1)
table.insert(t, ("image[%d,%d;1,1;%s]"):format(x, y, E(tmod)))
end
end
minetest.show_formspec("singleplayer", "dev:test", table.concat(t))
end) |
Fixes #14312 (last commit), among two doc improvements.
How to test
Observe that the regression has regressed. Read the docs and commit messages.