Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two tiny doc things, combine regression fix #14314

Merged
merged 3 commits into from Jan 28, 2024

Conversation

appgurueu
Copy link
Contributor

Fixes #14312 (last commit), among two doc improvements.

How to test

Observe that the regression has regressed. Read the docs and commit messages.

@appgurueu appgurueu added @ Documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug labels Jan 27, 2024
Copy link
Member

@grorp grorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for the regression works.

The two documentation improvements could be squashed into one "Minor documentation fixes" commit.

doc/lua_api.md Outdated Show resolved Hide resolved
doc/lua_api.md Show resolved Hide resolved
@sfan5
Copy link
Member

sfan5 commented Jan 27, 2024

Replaced the fix with my own commit as discussed on IRC.

@appgurueu
Copy link
Contributor Author

I haven't tested the last commit well yet, but the logic should check out, and stuff (like signs) still looks right.

@sfan5 sfan5 removed the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label Jan 27, 2024
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will trust your testing

@appgurueu
Copy link
Contributor Author

Tested. Code:

minetest.after(1, function()
	local E = minetest.formspec_escape
	local t = {"size[4,4]"}
	for x = 0, 1 do
		for y = 0, 1 do
			local tmod = ("[combine:2x2:0,0=rgbv.png:%d,%d=rgbv.png"):format(2*x-1, 2*y-1)
			table.insert(t, ("image[%d,%d;1,1;%s]"):format(x, y, E(tmod)))
		end
	end
	minetest.show_formspec("singleplayer", "dev:test", table.concat(t))
end)

Screenshot

rgbv.png

@appgurueu appgurueu merged commit 40bf88a into minetest:master Jan 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[combine texture modifier regression
3 participants