Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture modifiers and imageCleanTransparent are too slow #14322

Open
Desour opened this issue Jan 29, 2024 · 0 comments
Open

Texture modifiers and imageCleanTransparent are too slow #14322

Desour opened this issue Jan 29, 2024 · 0 comments

Comments

@Desour
Copy link
Member

Desour commented Jan 29, 2024

Performance issue.

This issue appears in at least two places:

How to test

  • Enable any texture filter stuff, like mip mapping, to trigger [applyfiltersformesh/imageCleanTransparent stuff.
  • Install signs_lib (https://github.com/mt-mods/signs_lib) and some luacmd fork (https://github.com/Desour/luacmd) in a mtg world.
  • Create some signs with different text on each: /lua local heren = here:round() for x = 0, 8 do for y = 0, 8 do for z = 0, 8 do local p = heren:offset(x,y,z) core.set_node(p, {name="default:sign_wall_wood",param2=2}) core.get_meta(p):set_string("text", p:to_string()..string.rep("\nAAAAAAA",5)) end end end
  • Rejoin.
  • Notice how the client freezes. when the sign objects load.
    Edit: To measure, show the F5 profiler graphs, and look at "Time non-rendering [us]".

Here's a flamegraph:

2024-01-29-220615_1920x1080_scrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant