Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC build access violation crash since "Clean up client and server command sending / tables" #14324

Closed
blaboing opened this issue Jan 29, 2024 · 1 comment
Closed

MSVC build access violation crash since "Clean up client and server command sending / tables" #14324

blaboing opened this issue Jan 29, 2024 · 1 comment
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug Regression Something that used to work no longer does. Windows

Comments

@blaboing
Copy link

blaboing commented Jan 29, 2024 •
edited

Minetest version

Minetest 5.9.0-dev-397682a

Operating system and version

Win10

Summary

MSVC builds crash with access violation since 397682a on starting a singleplayer game or joining a public server.

running inside VS debugger it points to

Steps to reproduce

run Minetest 5.9.0-dev-397682a MSVC build
@blaboing blaboing added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Jan 29, 2024
@blaboing blaboing changed the title MSVC build access violation crash since https://github.com/minetest/minetest/commit/397682a5b08ae683431618ba52b6dec1829bcce3 MSVC build access violation crash since "Clean up client and server command sending / tables" Jan 29, 2024
@sfan5 sfan5 added Bug Issues that were confirmed to be a bug Blocker The issue needs to be addressed before the next release. Windows and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Jan 29, 2024
@savilli
Copy link
Contributor

savilli commented Jan 29, 2024

Replacing class Client; with class __multiple_inheritance Client; here

minetest/src/network/clientopcodes.h

Line 26 in 397682a

class Client;
should fix the issue.
See https://learn.microsoft.com/en-us/cpp/cpp/inheritance-keywords?view=msvc-170

@sfan5 sfan5 added the Regression Something that used to work no longer does. label Jan 30, 2024
@sfan5 sfan5 closed this as completed in e1f6108 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug Regression Something that used to work no longer does. Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sfan5 @blaboing @savilli