Don't use a reference for RaycastState::m_pointabilities #14376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desour
added
Trivial
|
You can consider it offtopic for this PR, but: We should allow Lua raycasts to specify |
sfan5
approved these changes
Feb 16, 2024
|
How about just referencing a nullopt with static lifetime (may be private to the function)? |
Would be possible, but unnecessarily complex imo. Also won't work if a mod provided pointabilities will be given to the lua raycast. |
appgurueu
pushed a commit
to y5nw/minetest
that referenced
this pull request
Mar 4, 2024
appgurueu
added a commit
to appgurueu/minetest
that referenced
this pull request
Mar 6, 2024
…etest#14376)" This reverts commit df6c96e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lua raycasts init the pointabilities with nullopt:
LuaRaycast *o = new LuaRaycast(core::line3d<f32>(pos1, pos2), objects, liquids, std::nullopt);Which of course has a too short lifetime.
(If you want to reduce copies,
shared_ptr<const Pointabilities>might work.)Bug introduced by #13992 (after my review :3).
To do
This PR is a Ready for Review.
How to test
testentities:selectionboxentity.