Restore pre-5.9.0-dev behavior of touch_use_crosshair=false shootline #14389
Conversation
|
Another case to consider is where the shootline should point before the player first touches the screen. In 5.8.0 and earlier, the shootline wasn't set at all in this case. This results in Irrlicht's
In 5.9.0-dev (and also with this PR), the pointer position is initialized as (0,0), so the shootline starts in the upper-left corner of the screen. Both behaviors are clearly stupid, the question is what the right behavior would be. |
grorp
force-pushed
the
touch-fix-id-reuse
branch
from
df4fa0d
to
fd711a9
Compare
…r=false This happened because Android reuses pointer IDs. Also includes a refactor to merge "m_known_ids" and "m_pointer_pos".
grorp
force-pushed
the
touch-fix-id-reuse
branch
from
fd711a9
to
128fa04
Compare
|
I've decided to simply restore the behavior before 5.9.0-dev: The shootline is initially at (0,0,0) -> (1,1,1) until you first move the camera/dig/place. After releasing the finger used to move the camera/dig/place, the shootline stays at it's current in-world position until it's needed again. #14188 is of course still fixed. This way, it will all work like it used to work and nobody will complain. You could put more work into this to find a perfect solution, but it really doesn't matter very much. |
grorp
changed the title
…minetest#14389) * Fix incorrect shootline after releasing pointer if touch_use_crosshair=false This happened because Android reuses pointer IDs. Also includes a refactor to merge "m_known_ids" and "m_pointer_pos". * Restore pre-5.9.0-dev behavior of shootline when !m_has_move_id
On Android with
touch_use_crosshair=false, if you move the camera, release your finger again and then put your finger on any on-screen button or the joystick, the shootline will be updated according to the new position of your finger. This happens because Android reuses pointer IDs.This bug was introduced by #14087. This PR fixes it by storing the position of the pointer used for the shootline separately.
We can't just use a zero-length shootline after the pointer is released because that breaks short-tapping.
To do
This PR is a Ready for Review.
How to test
As described above:
touch_use_crosshair=falsebefore this PR: the shootline is updated to start behind the joystick
after this PR: the shootline stays the same