Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting "pointabilities" for Lua raycasts #14390

Merged
merged 1 commit into from Mar 1, 2024

Conversation

grorp
Copy link
Member

@grorp grorp commented Feb 19, 2024

This PR allows setting the pointabilities field introduced by #13992 for Lua raycasts. This is useful for reproducing the results of client-side raycasts.

It's a trivial change, most of the diff is because I added a Devtest test case.

CC @cx384

To do

This PR is a Ready for Review.

How to test

  1. Start a Devtest game
  2. Place the "Not Pointable Node"
  3. Get yourself an "Ultimate Pointing Staff" and do a right-click on the "Not Pointable Node"
  4. See that the node is replaced by ice

Repeat the same thing with a "Blocked Pointing Staff", see that you cannot replace the node.

@grorp grorp added @ Script API Feature ✨ PRs that add or enhance a feature labels Feb 19, 2024
doc/lua_api.md Outdated Show resolved Hide resolved
@Zughy Zughy added the Supported by core dev Not on the roadmap, yet some core dev decided to take care of this PR label Feb 21, 2024
@sfan5 sfan5 self-requested a review February 29, 2024 07:59
doc/lua_api.md Outdated Show resolved Hide resolved
games/devtest/mods/unittests/raycast.lua Outdated Show resolved Hide resolved
games/devtest/mods/unittests/raycast.lua Outdated Show resolved Hide resolved
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grorp grorp merged commit e40417f into minetest:master Mar 1, 2024
15 checks passed
appgurueu pushed a commit to y5nw/minetest that referenced this pull request Mar 4, 2024
@grorp grorp deleted the lua-pointabilities branch April 1, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ✨ PRs that add or enhance a feature One approval ✅ ◻️ @ Script API Supported by core dev Not on the roadmap, yet some core dev decided to take care of this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants