Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetaData: restore undocumented set_string behaviour #14396

Merged
merged 1 commit into from Feb 25, 2024
Merged

MetaData: restore undocumented set_string behaviour #14396

merged 1 commit into from Feb 25, 2024

Conversation

SmallJoker
Copy link
Member

@SmallJoker SmallJoker commented Feb 21, 2024 •
edited

Fixes #14391

To do

This PR is Ready for Review.>

How to test

  1. Devtest game
  2. /unittests
  3. All tests must pass.

@SmallJoker SmallJoker added @ Script API Bugfix 🐛 PRs that fix a bug labels Feb 21, 2024
sfan5
sfan5 requested changes Feb 21, 2024
View reviewed changes
games/devtest/mods/testmetadata/init.lua Outdated Show resolved Hide resolved
src/script/lua_api/l_metadata.cpp Outdated Show resolved Hide resolved
@Zughy Zughy added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Feb 21, 2024
@SmallJoker SmallJoker removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Feb 22, 2024
sfan5
sfan5 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good otherwise

@sfan5 sfan5 added this to the 5.9.0 milestone Feb 23, 2024
@rollerozxa rollerozxa mentioned this pull request Feb 25, 2024
Closed
@SmallJoker SmallJoker merged commit fa1d80b into minetest:master Feb 25, 2024
15 checks passed
appgurueu pushed a commit to y5nw/minetest that referenced this pull request Mar 4, 2024
@SmallJoker @appgurueu
MetaData: restore undocumented set_string behaviour (minetest#14396)
5b60799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️ @ Script API
Projects
None yet
Milestone
5.9.0
3 participants
@SmallJoker @sfan5 @Zughy