Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jpeg-turbo as the default library for compiling in macOS #14398

Merged
merged 1 commit into from Feb 23, 2024

Conversation

ShadowRoi
Copy link
Contributor

Fix jpeg compiling by making it jpeg-turbo as the default

Add compact, short information about your PR for easier understanding:

  • Goal of the PR
    Fix macOS compiling
  • How does the PR work?
    changing library from jpeg to jpeg-turbo
  • Does it resolve any reported issue?
    Yes it resolves CMake failure on macOS? #14386 . At least I hope so.
  • Does this relate to a goal in the roadmap?
    No, probably.

Ready for Review.

How to test

Attempt to compile Minetest for macOS. I don't know if previously compiling was broken only to Apple Silicon or any MacBook.

Fix jpeg compiling by making it jpeg-turbo as the default
@sfan5 sfan5 added @ Documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Feb 21, 2024
@sfan5 sfan5 merged commit 6952bab into minetest:master Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake failure on macOS?
2 participants