Use forward-slash (/) for path separator in translation files #14399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lstrip (left trim) call is to make sure that there are no slashes at the beginning of file paths.
srifqi
added
@ Startup / Config / Util
@ Translation
Bugfix 🐛
sfan5
approved these changes
Feb 23, 2024
sfan5
added
Trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of the PR
This PR aims to make file path separators (in
*.trfiles) uniform across platforms (/).How does the PR work?
This PR adds string replacement by splitting the path (depends on OS) and joining it again using forward-slash (
/). Thelstrip(left trim) call is to make sure that there are no slashes at the beginning of file paths.Does it resolve any reported issue?
This PR tries to fix #14089.
To do
This PR is Ready for Review.
How to test
-pflag for a mod with scripts inside folders./).