Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no squash] Fix node callbacks unit test #14406

Merged
merged 2 commits into from Mar 3, 2024
Merged

[no squash] Fix node callbacks unit test #14406

merged 2 commits into from Mar 3, 2024

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Feb 24, 2024 •
edited

first commit:

00:37 <+sfan5> >call get_node_or_nil
00:37 <+sfan5> >it returns "ignore" because the area is unloaded
00:37 <+sfan5> I am being trolled
00:51 <+sfan5> so apparently blocks get created when the mapgen is invoked but contents only appear once the mapgen finishes
00:51 <+sfan5> not sure if that's a bug

@sfan5 sfan5 added the Bugfix 🐛 PRs that fix a bug label Feb 24, 2024
@sfan5
Fix node callbacks unit test
9d32933
@sfan5
Fix core.get_node_or_nil in emerge env
c3594ee 
"ignore" does not mean unloaded, we have to properly check it.
@sfan5 sfan5 changed the title Fix node callbacks unit test [no squash] Fix node callbacks unit test Feb 24, 2024
Desour
Desour approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Desour Desour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Devtest unittests also pass. 👍

@sfan5 sfan5 merged commit e734b3f into minetest:master Mar 3, 2024
15 checks passed
@sfan5 sfan5 deleted the branch2402 branch March 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desour Desour Desour approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfan5 @Desour