Add support for ContentDB package translation #14410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
added
@ Translation
Feature ✨
Whilst unused by ContentDB currently, this will allow localising the package list in the future.
rubenwardy
force-pushed
the
contentdb_languages
branch
from
735cad2
to
d6f5f1e
Compare
30 tasks
sfan5
reviewed
Feb 25, 2024
sfan5
approved these changes
Feb 25, 2024
Draft
12 tasks
appgurueu
pushed a commit
to y5nw/minetest
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst not implemented by ContentDB yet, including "Accept-Language" will allow localizing the package list in the future.
To do
This PR is Ready for Review
How to test
nc -l -p 8080contentdb_url = http://localhost:8080Accept-Language: enin request headersLANGUAGEand the language setting), and open the ContentDB dialogAccept-Language: fr, en;q=0.8in request headersAdditional context
Accept-Language on mdn
ContentDB PR (this PR can be merged before the CDB PR)