Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object:set_properties() should only send changed properties #14418

Open
GreenXenith opened this issue Feb 29, 2024 · 0 comments
Open

object:set_properties() should only send changed properties #14418

GreenXenith opened this issue Feb 29, 2024 · 0 comments
Labels
Concept approved Approved by a core dev: PRs welcomed! @ Network Performance Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. @ Script API

Comments

@GreenXenith
Copy link
Member

GreenXenith commented Feb 29, 2024 •
edited

Problem

When object:set_properties() is called, all properties are sent in a single packet to clients. This packet can be rather large. It is a waste to send unchanged properties. This issue is functionally identical to #9934 (excess network packets being generated for unchanged properties) with the more generic idea that packets should not be sent for properties that do not change.

Solutions

A new packet type or different structure would be needed to let the server send individual properties (or sets of properties).
@GreenXenith GreenXenith added the Feature request Issues that request the addition or enhancement of a feature label Feb 29, 2024
@sfan5 sfan5 added @ Script API @ Network Concept approved Approved by a core dev: PRs welcomed! labels Feb 29, 2024
@Desour Desour added Performance Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. and removed Feature request Issues that request the addition or enhancement of a feature labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Concept approved Approved by a core dev: PRs welcomed! @ Network Performance Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. @ Script API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sfan5 @Desour @GreenXenith