[no sq] Fix some common SAO methods to not generate useless update packets #14419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Testing whether the updates still work properly:
☑️ Object properties (devtest testtools:object_editor), binoculars (zoom_fov)
☑️ FoV player:set_fov(11, false, 1)
☑️ Formspec (inventory)
☑️ setTextureMod -> self.object:set_texture_mod("^[transform1")
Minor code style remarks. Feel free to fix if wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9934
To do
This PR is Ready for Review.
How to test
There's test code in 9934 for
set_object_propertiesbut you have to make up your own for the rest.