[no sq] Server bug fixes and unit tests #14423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check how easily I can test it from C++. Devtest is challenging due to missing direct control and insight into this part. |
This comment was marked as resolved.
This comment was marked as resolved.
|
@grorp Tests added. |
nerzhul
requested changes
Mar 5, 2024
| delete m_thread; | ||
| // Note that this also deletes and saves the map. | ||
| delete m_env; | ||
| m_env = nullptr; |
There was a problem hiding this comment.
setting m_env to nullptr in destructor means we have a scope issue somewhere in the destruction. Which code part uses m_env after that and will break ? (it means we should find a wait to split some objects at a moment)
There was a problem hiding this comment.
this is just good practice to not leave dangling pointers around
|
|
||
| // Activate object | ||
| if (object->m_static_exists) | ||
| { |
There was a problem hiding this comment.
intentional so I can properly place the comment before else, suggestions welcome
Desour
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do
This PR is a
Work in Progress/ Ready for Review.How to test
static_save = falseare persisted #14420static_save = falseare persisted #14420 and a revision before commit 4 to create a world with statically saved objects that shouldn't be static