Remove excessive touchscreengui.h includes #14466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, I thought I had done this already. This allows removing the touchscreengui.h include from inputhandler.h It's also cleaner.
grorp
added
Maintenance
grorp
commented
Mar 16, 2024
There was a problem hiding this comment.
I know it looks bad that the whole content of the clientdynamicinfo.cpp is inside #ifndef SERVER, but since clientdynamicinfo.h is also used on the server, I can't just move both files into the client folder.
SmallJoker
approved these changes
Mar 16, 2024
sfan5
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #14456, I noticed that recompiling after changes to
touchscreengui.htakes way too long.To fix that, this PR ...
touchscreengui.hfrom header files to cpp files.MyEventReceiver::m_touchscreenguimember.To do
This PR is a Ready for Review.
How to test
See that the touch controls still work.
See that I didn't change the code while moving it. See that it compiles.