-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add physics overrides for walk speed and Fast Mode (adoption) #14475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorp
added
@ Script API
Feature ✨
PRs that add or enhance a feature
@ Client / Controls / Input
Supported by core dev
Not on the roadmap, yet some core dev decided to take care of this PR
labels
Mar 19, 2024
sfan5
reviewed
Apr 29, 2024
sfan5
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks correct, feel free to merge if tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@ Client / Controls / Input
Feature ✨
PRs that add or enhance a feature
@ Script API
Supported by core dev
Not on the roadmap, yet some core dev decided to take care of this PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an adoption of #13815 by Wuzzy2. I rebased and fixed a bug in the backwards compatibility code.
This PR adds the following new fields to
set_physics_override
:speed_walk
: Normal walking speedspeed_fast
: Speed in Fast Modeacceleration_fast
: Acceleration in Fast ModeWith this PR, every player physics value (
movement_
settings) will be overridable by Lua.To do
This PR is a Ready for Review.
How to test
Quoting Wuzzy2:
Also test backwards compatibility with all different client/server combinations: this PR / 5.8.0 / pre-5.8.0 on the client + this PR / 5.8.0 / pre-5.8.0 on the server