Turn dos files into unix files #14484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zughy
added
Maintenance
sfan5
reviewed
Mar 23, 2024
sfan5
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I wrote a script to check for trailing whitespace (and other file format things. e.g. for png meta data) to hopefully add it to the Minetest GitHub workflow someday, I noticed that some dos files sneaked into the codebase (CRLF instead of just LF).
To me, this is annoying, since I don't like the format and they have to be treated differently for my script, but if you don't care you can also close this PR.
So this PR Turns them into proper Unix files to have at least some consistency.
I also added it to
.gitattributes, to not add CRLF files in the future.(Maybe
text=autowould be enough, but I don't see a reason to not useeol=lf.)To do
This PR Ready for Review.
How to test
git ls-files | xargs file | grep CRLFor
git ls-files --eol | grep crlf(It's also interesting how inconsistent the filetyps are
file -k <file>)