Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests that rely on UTF-8 literals #14490

Merged
merged 1 commit into from Mar 28, 2024
Merged

Fix tests that rely on UTF-8 literals #14490

merged 1 commit into from Mar 28, 2024

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Mar 24, 2024

you can see the difference in the MSVC CI test run

@sfan5 sfan5 added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug labels Mar 24, 2024
grorp
grorp reviewed Mar 27, 2024
View reviewed changes
src/util/string.h Outdated Show resolved Hide resolved
src/util/string.h Show resolved Hide resolved
@sfan5
Fix tests that rely on UTF-8 literals
b6e8700 
and the lowercase function
@sfan5 sfan5 merged commit d307d01 into minetest:master Mar 28, 2024
13 checks passed
@sfan5 sfan5 deleted the utf8test branch March 28, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grorp grorp grorp approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfan5 @grorp