Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add "long tap to punch" as a client-side setting
Fixes the part of The touch_interaction introduced in 404a063fdfbbddcba32d22dd1c34dd73922bc12a needs a setting to override it #14393 that I consider acceptable. The setting doesn't seem useful to me, but it will hopefully make @j-r happy ¯\(ツ)/¯
Typical Minetest workflow:
Make long tap delay customizable and change default to 400ms
For comparison:
Add shorthand form for touch_interaction
Allows replacing this
with this
To do
This PR is a Ready for Review.
How to test
Verify that "short tap to punch" is still the default. Verify that the
touch_punch_gesture
setting can be used to restore the pre-5.9 behavior of "long tap to punch".Try different values for the
touch_long_tap_delay
setting.Add this code to Mineclon* and verify that it works: