Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep empty servers at bottom of list #14511

Merged
merged 1 commit into from Apr 5, 2024
Merged

Keep empty servers at bottom of list #14511

merged 1 commit into from Apr 5, 2024

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Apr 1, 2024 •
edited

fixes #14504

To do

This PR is Ready for Review.

How to test

  1. edit cache/common.conf to say geoip = OC
  2. view online tab in main menu
  3. list should visibly not be sorted by player count
  4. all empty servers should be reliably at the bottom

grorp
grorp approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@grorp grorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@sfan5 sfan5 merged commit 4e1679d into minetest:master Apr 5, 2024
2 checks passed
@sfan5 sfan5 deleted the listsort branch April 5, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grorp grorp grorp approved these changes

Assignees
No one assigned
Labels
@ Mainmenu One approval ✅ ◻️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0 online player servers should go to the bottom of the list
2 participants
@sfan5 @grorp