Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sounds: Queue more than two buffers if pitch is high #14515

Merged
merged 2 commits into from Apr 7, 2024

Conversation

Desour
Copy link
Member

@Desour Desour commented Apr 3, 2024

Fixes #14248.

To do

This PR is a Ready for Review.

How to test

With the devtest music box, play a long sound with high pitch (e.g. 5).

Pitch changes playback speed. So always enqueuing 2 buffers did not suffice
(and it was unnecessary complicated).
@Desour Desour added @ Client / Audiovisuals Bugfix 🐛 PRs that fix a bug Sounds 1 approval rule testing https://gist.github.com/celeron55/bf93a47442e418a629181908f68ffb0f labels Apr 3, 2024
@Desour Desour merged commit e12db0c into minetest:master Apr 7, 2024
13 checks passed
@Desour Desour deleted the sound_queue_not_always_two branch April 7, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval rule testing https://gist.github.com/celeron55/bf93a47442e418a629181908f68ffb0f Bugfix 🐛 PRs that fix a bug @ Client / Audiovisuals Sounds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sound queue ran empty" with pitch shift
1 participant