[no sq] Use Minetest's wide/utf8 conversion function from inside Irrlicht #14523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
added
Maintenance
removes any dynamic linking capability, which will stop being possible soon anyway.
Closed
|
I've tested this and it fixes the error reported in #14527. However, there still seems to be some problem with emojis on Windows. With
On Windows, doing the same (obviously with a different font path) results in this instead:
|
|
since windows has 16-bit wchar surrogate-pairs might be involved here 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gets rid of the annoying
codecvtdeprecation warning