Print filenames in irrlicht png warnings #14525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings like these are useless, because you don't know which file causes it:
WARNING[Main]: Irrlicht: PNG warning: iCCP: known incorrect sRGB profile
With PR, it looks like this:
WARNING[Main]: Irrlicht: PNG warning for abriglass_clearglass.png: iCCP: known incorrect sRGB profile
(libpng docs: http://www.libpng.org/pub/png/libpng-manual.txt)
The change in
CNullDriver::createImageFromFile
is needed because the jpg loader complains with an error if the file doesn't have the jpg signature.isALoadableFileFormat
only has false negatives in the case of "very old tgas", according to tga loader code comment.Do we support those?
To do
This PR is a Ready for Review.
How to test
https://github.com/mt-mods/abriglass/blob/2e8968dc0f72952c9d8ace1fed397f5c4e985168/textures/abriglass_clearglass.png