Backport 5.8.1 (Android-only) #14548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code relied on touch IDs being consecutive. This is true on Android, but not on Linux. Therefore, touch input on Linux was broken since 53886dc.
grorp
added
the
Maintenance
grorp
force-pushed
the
backport-5.8.1
branch
2 times, most recently
from
8e97fa1
to
af1d45f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
LGTM. |
|
I found a regression which should be fixed first: #14561 Also, this PR doesn't contain a commit produced by |
sfan5
added
the
WIP
grorp
removed
the
WIP
The notification channel creation is moved into MainActivity. The notification channel ID string is stored into a static variable. The name and description of the notification channel are stored into the strings resource file. Co-authored-by: sfan5 <sfan5@live.de>
…cially on Android) (minetest#14266)
The recently added ioctl use is reported as a false-positive by valgrind. I tried moving it to different compilers/versions two times and only hit further issues that were valgrind's fault. Also includes a tiny fix.
Test case:
```
$ cmake . -DRUN_IN_PLACE=TRUE -DCMAKE_BUILD_TYPE=Release -DBUILD_SERVER=TRUE -DENABLE_TOUCH=FALSE
minetest minetestserver
W/o LTO: 13M 7.3M
W/ LTO: 11M 5.9M
difference: 15% 19%
```
Also fixes various compiler warnings resulting from compilation using LTO.
---------
Signed-off-by: David Heidelberg <david@ixit.cz>
- Allow disabling of the post processing pipeline while leaving shaders enabled - Also disable post processing on Android by default
It's close to impossible to test locally built changes otherwise.
Co-authored-by: sfan5 <sfan5@live.de>
I think so. |
|
ping @rubenwardy |
SmallJoker
approved these changes
May 6, 2024
There was a problem hiding this comment.
Things tested: (Android 6.0, self-signed apk from GitHub actions)
☑️ Minetest Game install from Content DB
☑️ World creation (includes text input)
☑️ Singleplayer world
☑️ Formspec inputs / formspec close / tooltips / Stack movement / Crafting
☑️ Autojump / node dig / node placement / node "rightclick"
☑️ Settings dialogue
☑️ Remote server join
Works for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at an Android-only 5.8.1 release. Please tell me if I have forgotten a commit or something.
The "pause rendering" stuff is intentionally omitted for being hairy (and also for requiring the creation of a new Irrlicht version by means of cherry-picking).