New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor main #1644
Closed
Closed
Refactor main #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*/ | ||
if ((ENABLE_TESTS && cmd_args.getFlag("disable-unittests") == false) | ||
|| cmd_args.getFlag("enable-unittests") == true) { | ||
run_tests(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't indented correctly. This is correct:
if ((ENABLE_TESTS && cmd_args.getFlag("disable-unittests") == false)
\t \t || cmd_args.getFlag("enable-unittests") == true) {
\t run_tests();
}
ShadowNinja
added
@ Startup / Config / Util
Maintenance
Tasks to keep the codebase and related parts in order, including architectural improvements
labels
Sep 20, 2014
ShadowNinja
force-pushed
the
master
branch
4 times, most recently
from
September 22, 2014 01:03
73b8c08
to
56195dc
Compare
Zeno-
added
WIP
The PR is still being worked on by its author and not ready yet.
Testing needed
and removed
WIP
The PR is still being worked on by its author and not ready yet.
labels
Nov 11, 2014
@kahrl ... changes incorporated (except for those terrible playername etc) |
@@ -1884,14 +1789,12 @@ int main(int argc, char *argv[]) | |||
#endif | |||
|
|||
} //try | |||
catch(con::PeerNotFoundException &e) | |||
{ | |||
catch(con::PeerNotFoundException &e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add space before (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Maintenance
Tasks to keep the codebase and related parts in order, including architectural improvements
@ Startup / Config / Util
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure and refactor main.cpp (in particular main() itself)