Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor main #1644

Closed
wants to merge 1 commit into from
Closed

Refactor main #1644

wants to merge 1 commit into from

Conversation

Zeno-
Copy link
Contributor

@Zeno- Zeno- commented Sep 17, 2014

Restructure and refactor main.cpp (in particular main() itself)

*/
if ((ENABLE_TESTS && cmd_args.getFlag("disable-unittests") == false)
|| cmd_args.getFlag("enable-unittests") == true) {
run_tests();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't indented correctly. This is correct:

if ((ENABLE_TESTS && cmd_args.getFlag("disable-unittests") == false)
  \t    \t    || cmd_args.getFlag("enable-unittests") == true) {
  \t    run_tests();
}

@ShadowNinja ShadowNinja added @ Startup / Config / Util Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Sep 20, 2014
@Zeno- Zeno- added WIP The PR is still being worked on by its author and not ready yet. Testing needed and removed WIP The PR is still being worked on by its author and not ready yet. labels Nov 11, 2014
@Zeno-
Copy link
Contributor Author

Zeno- commented Nov 19, 2014

@kahrl ... changes incorporated (except for those terrible playername etc)

@@ -1884,14 +1789,12 @@ int main(int argc, char *argv[])
#endif

} //try
catch(con::PeerNotFoundException &e)
{
catch(con::PeerNotFoundException &e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space before (

@Zeno-
Copy link
Contributor Author

Zeno- commented Nov 22, 2014

d6cc0d8

@Zeno- Zeno- closed this Nov 22, 2014
@Zeno- Zeno- deleted the refactor_main branch November 24, 2014 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements @ Startup / Config / Util
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants