Fix raillike bug (currently manifests itself on Android), and minor improvement to readability. #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowNinja
added
Android
@ Client / Audiovisuals
Bug
KodexKy
force-pushed
the
raillike_fix
branch
from
c075ca5
to
eed924b
Compare
|
Is this Android only? |
|
Only Android seems to need this. Linux and windows builds work as expected either way. |
|
Ok so from what I can see in the diff, it seems that Android has unsigned char (and char could be unsigned on other devices or compilers as well, so this is a more general bug that just happened to show up on Android first). |
Zeno-
changed the title
Zeno-
changed the title
|
Merged b9bc8da |
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects this annoying bug: https://forum.minetest.net/viewtopic.php?f=3&t=9389&start=75#p149910 where horizontal raillikes will shoot into the sky.