Respect game mapgen flags and save world noise params #2404
Conversation
ShadowNinja
added
Bug
|
This is beyond my knowledge and i trust ShadowNinja has done this correctly, so approved. |
|
Seems good for me. You can merge after fixing some comments: |
| override_default_settings(g_settings, &gamedefaults); | ||
| // Create world if it doesn't exist | ||
| if(!initializeWorld(m_path_world, m_gamespec.id)) | ||
| throw ServerError("Failed to initialize world"); |
There was a problem hiding this comment.
No, don't use an exception, please set a proper message and exit(1);
There was a problem hiding this comment.
I agree with this (no need for an exception... just msg and abort)
In general I think that exceptions are used in a way that is not "good practice" throughout minetest. We shouldn't be adding/throwing more exceptions. All exceptions should follow "termination semantics" (rather than "resumption semantics" as they are in many instances throughout minetest) and in that case you may as well just... well, print a msg and abort. If resumption is appropriate then it should not be an exception at all, the "error" handled in some way and program resumes
There was a problem hiding this comment.
- I just moved this.
- The client can't catch and display
abort()/exit().
ShadowNinja
force-pushed
the
fix-map-meta-save
branch
2 times, most recently
from
75de796
to
0adb522
Compare
ShadowNinja
force-pushed
the
fix-map-meta-save
branch
from
0adb522
to
f6e4c5d
Compare
Rebase of #2211.
Also adds some
constkeywords where appropriate.