Tests: Modularize unit testing #2654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwolekr
force-pushed
the
master
branch
2 times, most recently
from
133c31f
to
3a4d829
Compare
Split unit tests into separate files under src/unittest/ Give better unittest diagnostics Clean up some code
| FILESYS_CASE_INSENSITIVE is true | ||
| */ | ||
| int expected_results[numpaths][numpaths] = { | ||
| {1,2,0,0,0,0,0,0,0,0,0,0}, |
There was a problem hiding this comment.
Did this get fixed? Last I checked it actually failed on Windows but since the unit test seemed more complicated than the actual function that it tests it was never fixed (AFAIK)
There was a problem hiding this comment.
I didn't modify the contents of this test at all. I believe it did get fixed at some point, not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split unit tests into separate files under src/unittest/
Give better unittest diagnostics
Clean up some code
Here is the new output of unit testing:
http://fpaste.org/215528/29131143/