Use CUSTOM_LOCALEDIR if specified #3108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowNinja
added
Bug
| #ifdef STATIC_LOCALEDIR | ||
| if (STATIC_LOCALEDIR[0] != '\0') | ||
| path_locale = STATIC_LOCALEDIR; | ||
| else |
There was a problem hiding this comment.
I suggest removing the "else" to fix the indentation on the following code line.
There was a problem hiding this comment.
That would break it, the later line would reset path_locale.
Is this better?
#ifdef STATIC_LOCALEDIR
path_locale = STATIC_LOCALEDIR[0] ? STATIC_LOCALEDIR : getDataPath("locale");
#else
path_locale = getDataPath("locale");
#endif
sfan5
added
low-priority enhancement
and removed
Bug
|
Looks good, although I as well haven't tested it. |
ShadowNinja
force-pushed
the
fix-custom-locale-dir
branch
from
80e5d89
to
fb7e8ed
Compare
|
@sfan5: This is a bug, as |
ShadowNinja
added
Bug
|
May be relevant for merging: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1582 (although I haven't tested it).