Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s_base.cpp compile error with -std=c++11 #3512

Closed
MoNTE48 opened this issue Jan 1, 2016 · 6 comments
Closed

s_base.cpp compile error with -std=c++11 #3512

MoNTE48 opened this issue Jan 1, 2016 · 6 comments
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug @ Build CMake, build scripts, official builds, compiler and linker errors High priority

Comments

@MoNTE48
Copy link
Contributor

MoNTE48 commented Jan 1, 2016

jni/../jni/src/script/cpp_api/s_base.cpp: In constructor 'ScriptApiBase::ScriptApiBase()':
jni/../jni/src/script/cpp_api/s_base.cpp:71:22: error: no matching function for call to 'std::mutex::mutex(bool)'
m_luastackmutex(true)
^
In file included from jni/src/threading/mutex.h:31:0,
from jni/src/threads.h:41,
from jni/src/script/cpp_api/s_base.h:31,
from jni/../jni/src/script/cpp_api/s_base.cpp:20:
/home/server/crystax/sources/cxx-stl/gnu-libstdc++/5/include/mutex:126:5: note: candidate: constexpr std::mutex::mutex()
mutex() noexcept = default;
^
/home/server/crystax/sources/cxx-stl/gnu-libstdc++/5/include/mutex:126:5: note: candidate expects 0 arguments, 1 provided
[armeabi-v7a] Compile++ thumb: minetest <= s_node.cpp
make[2]: [obj/local/armeabi-v7a/objs/minetest/jni/src/script/cpp_api/s_base.o] Error 1

@est31
Copy link
Contributor

est31 commented Jan 1, 2016

This seems like its caused by 52e5b51 .

Most likely "normal" c++11 mode is broken as well, I'm not sure, at least I can't find any docs of the method with one param: http://en.cppreference.com/w/cpp/thread/recursive_mutex

@est31
Copy link
Contributor

est31 commented Jan 1, 2016

Err, that's the class we should use if the param is true.

This is the docs for std::mutex of course:
http://de.cppreference.com/w/cpp/thread/mutex

@est31 est31 added the Bug Issues that were confirmed to be a bug label Jan 1, 2016
@est31 est31 changed the title s_base.cpp error with Crystax NDK s_base.cpp compile error with --std=c++11 Jan 17, 2016
@est31
Copy link
Contributor

est31 commented Jan 17, 2016

I confirm, 52e5b51 broke normal compilation with c++11 as well, bad bad.

@est31 est31 added Blocker The issue needs to be addressed before the next release. @ Build CMake, build scripts, official builds, compiler and linker errors High priority labels Jan 17, 2016
@est31
Copy link
Contributor

est31 commented Jan 17, 2016

Added blocker label, we can't release something that can't be built with c++11, and the bug is nicely reproducible and can be fixed quite easily.

@est31 est31 changed the title s_base.cpp compile error with --std=c++11 s_base.cpp compile error with -std=c++11 Jan 17, 2016
@est31
Copy link
Contributor

est31 commented Jan 19, 2016

@kwolekr do you want to fix it?

@est31
Copy link
Contributor

est31 commented Jan 23, 2016

Fixed by e50c784

@est31 est31 closed this as completed Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug @ Build CMake, build scripts, official builds, compiler and linker errors High priority
Projects
None yet
Development

No branches or pull requests

2 participants