Improve waving definitions #3515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow more drawtypes to use waving (firelike, mesh, nodebox) - Don't hardcode waving type, defined by nodedef
|
https://github.com/minetest/minetest/pull/3515/files?w=1 l need waving glass for birch leaves. |
|
static const u8 offset = 3; please |
|
Possibly replaced by #3497 |
paramat
added
the
Adoption needed
|
Partially replaced by #3497 |
|
Sofar and nerzhul agreed on closing. The author is gone and the pull gets replaced by ^. |
|
I agree to close too. |
Zughy
removed
the
Adoption needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from https://github.com/blockplanet/blockplanet. Since I'm the copyright holder and doin this PR here it can be used ofc.