Show infotext with description for item entities #3547
Conversation
RealBadAngel
commented
Jan 8, 2016
RealBadAngel
commented
| @@ -1850,5 +1850,10 @@ std::string GenericCAO::debugInfoText() | |||
| return os.str(); | |||
| } | |||
|
|
|||
| std::string GenericCAO::infoText() | |||
There was a problem hiding this comment.
no, set this definition to content_cao.h directly to permit inlining implictly by compiler.
There was a problem hiding this comment.
Also, return const std::string instead of std::string
|
Can you document the new field in lua_api.txt? |
|
@PilzAdam done |
RealBadAngel
force-pushed
the
item_infotext
branch
from
2962dae
to
1e8d376
Compare
|
👍 |
|
@PilzAdam remove bad suggestions about virtual operator :) |
|
I'd like to give this a +1 but there's no description of what it does, is the top screenshot the before or the after? How does this change the information shown? |
|
Why is the infotext shown in the top left part of the minetest window and not next to the + cursor? |
I don't think that either are the before/after screenshots. From the small bit of testing that I've done, it seems that the top one is how it looks without debug info, and the bottom one is with debug info on.
It makes the info in debug mode (hp & armor groups) appear a line further down the screen, and (somewhat obviously!) shows the "infotext" of the item being pointed at. |
|
@HybridDog infotext is shown at the same position like for nodes, its fixed. |
|
Tested this and it's great, simple implementation as well, so 👍 from me. |
|
@RealBadAngel i'm okay with your PR except the inlining comments |
|
@nerzhul ah, forgot bout that, will do that later today |
|
👍 |
RealBadAngel
force-pushed
the
item_infotext
branch
from
7bcabea
to
8aa085a
Compare
Partially reverts #3547 Infotext remains optional for objects, empty by default
