Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private field 'm_selection_active' is not used #3698

Closed
ExcaliburZero opened this issue Feb 13, 2016 · 0 comments
Closed

Private field 'm_selection_active' is not used #3698

ExcaliburZero opened this issue Feb 13, 2016 · 0 comments
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements

Comments

@ExcaliburZero
Copy link
Contributor

I was recently compiling minetest using the AUR build script minetest-git-leveldb and, while the program did compile correctly, there was a compiler error:

[ 48%] Building CXX object src/CMakeFiles/minetest.dir/guiFormSpecMenu.cpp.o
In file included from /home/chris/Programs/minetest-git-leveldb/src/minetest/src/guiFormSpecMenu.cpp:26:
/home/chris/Programs/minetest-git-leveldb/src/minetest/src/guiFormSpecMenu.h:404:20: warning: private field 'm_selection_active' is not used
      [-Wunused-private-field]
        bool              m_selection_active;
                          ^
1 warning generated.

I used GitHub's search function to look through the repository to see where that variable is used, and it looks like it is only used in the one file mentioned in the warning message.

I did a quick search of that file and it appears that the variable mentioned in the warning is not used any place other than it's declaration.

Is this variable unused? If so then it may be a good idea to remove it in order to get rid of the compiler warning.

@est31 est31 added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Feb 13, 2016
@est31 est31 closed this as completed in bd43933 Feb 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements
Projects
None yet
Development

No branches or pull requests

2 participants