Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapblock mesh: Eliminate meshgen lags #3717

Closed
wants to merge 1 commit into from

Conversation

RealBadAngel
Copy link
Contributor

using reserve seems to be completely not a speedup at all
fix for #3714

@paramat
Copy link
Contributor

paramat commented Feb 16, 2016

@kahrl
Copy link
Contributor

kahrl commented Feb 16, 2016

👍

@paramat
Copy link
Contributor

paramat commented Feb 16, 2016

Will merge soon.

@paramat
Copy link
Contributor

paramat commented Feb 16, 2016

0851724

@paramat paramat closed this Feb 16, 2016
@est31
Copy link
Contributor

est31 commented Feb 16, 2016

I just wondered wtf this is slow, I've thought using reserve would be beneficial...

I guess what hmmm and kahrl's theory is the right one, that the reserve(n) implementation reserves exactly n elements. push_back on the other hand reserves 2^k >= n elements for minimal k... (for both gcc and clang implementation).

So it makes total sense that this was slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants