Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/deleteblocks causes map blackouts #3839

Closed
0-afflatus opened this issue Mar 11, 2016 · 15 comments
Closed

/deleteblocks causes map blackouts #3839

0-afflatus opened this issue Mar 11, 2016 · 15 comments
Labels
Not a bug The behaviour is working as intended and won't be changed.

Comments

@0-afflatus
Copy link

using /deleteblocks to repair mapgen anomalies appears to be deleting the light completely in those areas. I'll provide a screenshot if necessary, but I think this is pretty self-explanatory.
This is a major bug IMO.

@paramat paramat added Bug Issues that were confirmed to be a bug @ Mapgen labels Mar 11, 2016
@paramat
Copy link
Contributor

paramat commented Mar 11, 2016

Screenshot might be useful, please include the border of the dark area too. Also which mapgen?

@0-afflatus
Copy link
Author

mgv7

most of this appears to be caused by several invocations of /deleteblocks here 100
All three admins have spent time trying to /mapfix this yesterday and given up because it's just no fun at all.

screenshot_20160312_103248
screenshot_20160312_110843
screenshot_20160312_104434
screenshot_20160312_103932

I'll try to find some undamaged parts of the map and experiment with different invocations. However this damage is so extensive I think my only option is to unexplore large areas of the map.

@0-afflatus
Copy link
Author

Ice ...
I think these are pure mapgen errors
The border may be from a /mapfix

screenshot_20160313_192138
screenshot_20160313_193013
screenshot_20160313_193127

@paramat
Copy link
Contributor

paramat commented Mar 14, 2016

Does it happen in mgv6?
Running any mods or subgames? best disable them all.

@Fixer-007
Copy link
Contributor

I see moretrees here cough :} @paramat @VanessaE

@paramat
Copy link
Contributor

paramat commented Mar 15, 2016

Moretrees doesn't tend to cause shadows that big and over ocean. I'll check the deleteblocks code and see if it uses 'update lighting'. Please try without any mods enabled, and try in mgv6 too.

@0-afflatus
Copy link
Author

This is proving to be really difficult to debug.

This is a mapgen bug - specific to grailtest in multiplayer mode. If you take a brief glance at https://github.com/0-afflatus/grailtest and particularly https://github.com/0-afflatus/grailtest/blob/master/mods/default/mapgen.lua you'll see how difficult it would be to strip it down.

@Fixer-007 if you look at the screenshots, it's pretty obviously not caused by moretrees. As this is happening in dry treeless biomes equally. The lightbugs triggered by moretrees only occur in small patches and are easily /mapfix-able.

This only happens in multiplayer AFAICS - singleplayer works as expected.
In multiplayer all new areas (using various recent -dev versions) are generating without light. It's not just a patch it is the whole mapblock. If I do a /deleblocks here on an old (lit) mapblock, lightbugs are introduced. This can be fixed using /mapfix, but it's happening over such wide areas that it's almost impossible to make any headway (we have 5 players on the case right now)

I'm really sorry, but setting up a multiplayer server running mgv6 or any other mapgen is more work that I can handle right now - there are only so many hours in the day. From the lack of other responses, I guess that this doesn't happen in minetest_game at all. This is the best I can come up with after a solid week of investigation. I will persevere with getting some information you can work on @paramat

@paramat
Copy link
Contributor

paramat commented Mar 19, 2016

Weird. Don't bother trying in mgv6 since that's complex.

@paramat
Copy link
Contributor

paramat commented Mar 19, 2016

I looked through grailtest and can't see any obvious error. All i can suggest is removing the 'biomelib' 'moretrees' 'plantlife' mods to see if they are the cause.

@0-afflatus
Copy link
Author

I am working on this. So far I can report that mgv6 (in multiplayer mode) doesn't have this problem even with VanessaE's mods enabled. I will test without these mods, but I'm afraid this will take a few days more ...

@paramat
Copy link
Contributor

paramat commented Mar 21, 2016

Yes the overgeneration used in other mapgens seems to make lighting bugs worse.

@paramat
Copy link
Contributor

paramat commented Jul 8, 2017

@0-afflatus still occuring? We have had many lighting improvements recently.

@nerzhul
Copy link
Member

nerzhul commented Apr 15, 2020

can we have a confirmation on this issue ? else we may close the issue as it's 3 years old and we did some light fixes between

@paramat paramat added Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible and removed Bug Issues that were confirmed to be a bug Possible close labels Jul 24, 2020
@paramat paramat closed this as completed Jul 24, 2020
@0-afflatus
Copy link
Author

I've been away for 3 years, just catching up ...
I stopped using 'biomelib' 'moretrees' and 'plantlife' mods and haven't encountered lighting bugs since.
I also gave up trying to run a server or develop anything, so the above is kind of meaningless.
I seem to be working on games again.

@paramat
Copy link
Contributor

paramat commented Oct 24, 2020

Thanks, i appreciate the update.

@paramat paramat added Not a bug The behaviour is working as intended and won't be changed. and removed @ Mapgen Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not a bug The behaviour is working as intended and won't be changed.
Projects
None yet
Development

No branches or pull requests

5 participants