Surface material issue in mgvalleys

[paramat]

@duane-r
Not a blocker but if it can be fixed for release that's good.

[duane-r]

I can't tell what I'm looking at here. What do those blocks actually read as? Can you post a seed/location?

[duane-r]

The green on the side of the blocks is being caused by the snow side texture:
https://github.com/minetest/minetest_game/blob/master/mods/default/textures/default_snow_side.png

[ghost]

@duane-r , I believe he is referring to the dirt blocks on top of a snow layer.

[paramat]

Sorry it was an old deleted world. This may be around y = 47 but not sure, it was in rough mountainous terrain at fairly high altitude.
Yes the bug is surface biome nodes (dirt_with_grass/snow) below dirt blocks. The surface node should only be on the surface. This is strange i don't know how it happens.

[duane-r]

I haven't been able to duplicate this anywhere. It looks like a boundary issue, from what you're saying. I find lots of exposed stone at the chunk boundary, but that's about it.

I'm fairly sure the problem is not in the grass abm, given that it happened in so many blocks at once, but I can't see why generateBiomes would be dropping two surface blocks unless a second mapgen thread is rebuilding one of the chunks in a different way or there's a very tiny cave where air is being replaced by stone for structural support in the upper chunk after the cave puts down a surface block in the lower chunk. Maybe the removal of "node_max.Y + 1" in the cave method is an issue?

I hesitate to do anything without a repeatable case.

[DonBatman]

@duane-r I found the same thing. The pos and seed is in the image.
http://imgur.com/zErJTcU

[duane-r]

Well, I'm doing something wrong. This is my screenshot of the same place (I think).
http://duanerobertson.com/img/surface-material-problem-01.jpg

I'm using the latest code from master (as of last night), and no mods. I get no sand and no doubling. (And why would there be sand in one and not the other?) The terrain shape looks the same, so we've got the same noises.

Don, if you make another world with the same noise, does the problem come up consistently?

[DonBatman]

@duane-r This is from the latest master.
http://imgur.com/MXl3Aw5

Edit - I tried a new seed and can not find any issue. You must have fixed it!

[duane-r]

So you updated to the latest master and the doubling went away (but the odd sand is still there)? If that's so, do you remember the last time you pulled? Or did the problem just not carry over when you remade the world? (Or am I missing the problem again?)

[DonBatman]

I pulled yesterday. My first image was from a pull a couple days ago.
The latest build does not show the doubling.

[paramat]

Okay i think this was solved then by my recent commit to mgvalleys, my screenshot was from before that commit (sorry) thanks everyone for testing.

[paramat]

I think this was the code that placed biome surface nodes in tunnels misbehaving, somehting i fixed in all mapgens recently fe349d4