Additional hooks for inventory manipulations callbacks.

[Foghrye4]

Well, i screwed a little when i tried to remove 'minetest.clear_craft' from old master branch, so here is a new pull request.

For those, who does not saw #3962 this pull will add modding API function, which allow modders to trace any inventory changes (detached, nodemeta or player).

[t4im]

Mind the conventional plural-s on most other callback tables.

[t4im]

If you transfer an item from your creative inventory to a chest this will trigger at least two callbacks for essentially the same action.
Having everything in 9 different callbacks likely forces people to register something multiple times.

Can't you just pass the InvRef as first argument? Its get_location gives you type (player, nodemeta, detached) and position/name. You'd have to look it up anyway, first thing in a callback.

You could even combine all 9 into a single callback:

--- passed to core.register_on_inventory_change
function(from_inv, from_list, from_slot, to_inv, to_list, to_slot, stack, player)
  -- maybe we can allow to interrupt the inventory action? Or maybe even change it. 
  return
end

The parameters might seem a bit long, but if you account for the additional player, it is only 2 arguments longer than your current suggestion. And it is less verbose than having to create multiple callbacks.

Coming to think of it, why don't node callbacks do something similar?

[Foghrye4]

@t4im There is a reason for this. If you look up C++ code, you will see, that every change made passed by "InventoryList" object functions. Currently you can directly access lists and change their contents without using inventory object. As well, not only player can do so, but any script. As well you can get inventory reference from first argument of callback function (detached name or player or position).
Making list "know" where from comes new itemstack is complex. Currently inventory manager just delete itemstack in an old place and re-create it on a new place. Both source and destination list have they own listeners (which could be a same) and differ this movement case from any other cases would be very difficult and bring unnecessary complexity to code.

You are free to fork my work and modify it a way you want to.

[paramat]

Please squash commits to make it easier to review.

[Foghrye4]

@paramat Pull is rewritten on fresh version. Commits are squashed.

[sfan5]

What's the intended usage for register_on_nodemeta_inventory_* and register_on_detached_inventory_*?

[Foghrye4]

@sfan5 there is no such. Because callbacks implemented on server side inside InventoryList class, InventoryChangesReciever class, as Rubenwardy suggest, implemented in any inventory type, including detached and nodemeta. It could be used to trace all item movements for all players and mod actions. But I absolutely don't care about such movements.

[SmallJoker]

Replaced with #5647