Move join and left mesages to lua #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good. I don't think it needs to be exposed via the modding api. It will make it much much easier for server owners to customize the message now that's it in builtin. |
|
okay for me |
|
@HybridDog I think that is should be done in separate pull request, because objective of this PR is to move messages to builtin and to make them customizable. Not everybody would like to have grey colour. It should be discussed and not here. |
|
@HybridDog lol, you shouldn't delete your messages, you are breaking the discussion. And there is nothing to be sorry about(only about deleting your message). |
|
It'sn't even my idea #4454 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was reading #4454, I found out that messages that is written when player join and leave the game is defined in cpp. I don't see any reason for that, so I moved it to builtin. Now you can modify it by editing builtin lua.
I'm waiting for suggestion about how to make it customizable by mods(there are several ways). My opinion is that we shouldn't define any default, so if somebody would want those messages, they should be defined in mod.