New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix superflous shader setting updates #4800
Conversation
Since it's a WIP, I don't expect the memory-related problems have been addressed yet? For the record, if a "factory" is the best approach (and I can't really think of a better one, but it seems confusing) then I'm ok with that. Edit: SetSky() is similar to how I did it. I'm fine with that approach; it doesn't confuse things. |
It is 5th reincarnation of this PR, I hope you get it right this time once and for all. I guess I will use it daily. |
@Zeno-: The compare with uninitialized values has been fixed, the memory leak has not been fixed (yet). |
This improves rendering performance by ~40%
b711831
to
a6e870b
Compare
@Zeno-: Aaaaand fixed. (although I didn't have a few weeks to spare to wait for a valgrind run for confirmation...) This should be ready now. |
👍 |
This merge doesn't make any functional changes. It's a trivial style fix so that @gregorycu can be dual credited along with shadowninja for PR #4800
Congratulations to @gregorycu and everyone involved in this. |
Thank you @Fixer-007 . You were as involved as anyone else, so you should be pretty happy too! |
It's awesome to see this in. |
This can improve rendering performance by ~40%. (very hardware dependent)
Rebased version of #4530 with the following changes:
ShaderCallback
s instead of just leaking them.Sky**
thing with asetSky()
thing. It's still a bit ugly, but it works and it's maybe a little less ugly. (If you don't like it please offer a better solution)